-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/out of synch and requirement violation #618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blcham
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can be merged after resolution of mentioned issues.
…failure rate in FaultEventMenu - pass missing outOfSync parameter from currently edited fault tree to FaultEventMenu - fix styles outdated and violated values - allow icons to take any message not just string, useful to pass message as a component
…us from FaultTree
… than one message are rendered as an unordered list
…h warnings using FaultTreeStatus
…gs using FaultTreeStatus - pass faultTreeStatus as property from Editor
kostobog
force-pushed
the
fix/out-of-synch-and-requirement-violation
branch
from
October 8, 2024 08:02
391eb0c
to
c420c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blcham
Related backend PR
Fixes #607, #608, #598, #526.
Fixes partially #379 - Only the first option is implemented the other two options will require extending the backend model with information about the system of the referenced tree and the