Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/out of synch and requirement violation #618

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

kostobog
Copy link
Collaborator

@kostobog kostobog commented Oct 4, 2024

@blcham
Related backend PR

Fixes #607, #608, #598, #526.

Fixes partially #379 - Only the first option is implemented the other two options will require extending the backend model with information about the system of the referenced tree and the

  • the probability value saved in the external node is different from the calculated value of root node of the referenced fault tree
  • out of sync because of updated leaf nodes after fault tree evaluation
  • out of sync because of experimental evaluation (i.e. with MOH different from system MOH)

@kostobog kostobog requested a review from blcham October 4, 2024 15:21
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after resolution of mentioned issues.

public/locales/cs/translation.json Outdated Show resolved Hide resolved
src/components/Icons.tsx Outdated Show resolved Hide resolved
src/components/Icons.tsx Outdated Show resolved Hide resolved
…failure rate in FaultEventMenu

- pass missing outOfSync parameter from currently edited fault tree to FaultEventMenu
- fix styles outdated and violated values
- allow icons to take any message not just string, useful to pass message as a component
… than one message are rendered as an unordered list
…gs using FaultTreeStatus

- pass faultTreeStatus as property from Editor
@kostobog kostobog force-pushed the fix/out-of-synch-and-requirement-violation branch from 391eb0c to c420c78 Compare October 8, 2024 08:02
@kostobog kostobog merged commit 477683b into main Oct 8, 2024
1 check passed
@kostobog kostobog deleted the fix/out-of-synch-and-requirement-violation branch October 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple failure rate outdated messages to calculated failure rate in table of fta trees
2 participants