Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fta-fmea-ui#310 Implement persistent minimal operational and integration into API #119

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

kostobog
Copy link
Collaborator

@blcham
Related to kbss-cvut/fta-fmea-ui#310

Adds persistent min operational hours as property of OperationalDataFilter, integration with fault tree and ans system services and integration with fault tree rest api

Details

  • global min operational hours configurable via deployment parameter
  • system and fault tree summaries contain its own filter, system also contains global filter
  • provide api to update system and fault tree specific operational data filters
  • fault tree fetched with operational data filter
  • fault tree evaluation persists operational data filter into its context
  • system specific filter is persisted into system specific context

… as part of OperationalDataFilter, integration with fault tree and ans system services and integration with fault tree rest api

- global min operational hours configurable via deployment parameter
- system and fault tree summaries contain its own filter, system also contains global filter
- provide api to update system and fault tree specific operational data filters
- fault tree fetched with operational data filter
- fault tree evaluation persists operational data filter into its context
- system specific filter is persisted into system specific context
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see my comments

Consider adding description to methods.

}

/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing description.

}

/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing description.

}

/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing description.

@blcham blcham merged commit 3c98709 into main Jun 11, 2024
1 check passed
@blcham blcham deleted the feature/fta-fmea-310-min-op-hours branch June 11, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants