Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize error messages #151

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Localize error messages #151

merged 1 commit into from
Sep 13, 2024

Conversation

palagdan
Copy link
Collaborator

Resolves partially kbss-cvut/fta-fmea-ui#550

@blcham blcham force-pushed the 550-error-message-id branch from 693ef12 to 58c041c Compare August 30, 2024 14:48
@palagdan palagdan force-pushed the 550-error-message-id branch 2 times, most recently from a33b5e5 to 6d4866b Compare September 12, 2024 13:04
@palagdan palagdan requested a review from blcham September 12, 2024 13:05
blcham
blcham approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @kostobog have a look as well pls

src/main/java/cz/cvut/kbss/analysis/service/UserRepositoryService.java Outdated Show resolved Hide resolved
@palagdan palagdan force-pushed the 550-error-message-id branch from 6d4866b to 963a189 Compare September 13, 2024 11:33
@blcham blcham force-pushed the 550-error-message-id branch from 963a189 to 4cdafd3 Compare September 13, 2024 12:23
@blcham
Copy link
Contributor

blcham commented Sep 13, 2024

@kostobog hope this was ok to merge

@blcham blcham merged commit 2bbd821 into main Sep 13, 2024
1 check passed
@blcham blcham deleted the 550-error-message-id branch September 13, 2024 12:23
@kostobog
Copy link
Collaborator

@blcham
I guess it is ok. We should consider resolving the issues mentioned in the comments above.

@palagdan
Copy link
Collaborator Author

palagdan commented Sep 13, 2024 •
edited
Loading

@blcham @kostobog
I didn't provide messageIds for following exceptions:

  • (CalculationException, EntityNotFoundException, FtaFmeaException) These messages are generated on the backend and are not plain text.

  • (ExternalServiceException, PersistenceException, ResourceException) - These are 500 status exceptions, so it shouldn't provide any message explanation to the user, only logs for developer. Please correct me if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palagdan @blcham @kostobog