Feature/59 implement simple fault tree cutsets #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blcham
approved these changes
Feb 11, 2024
src/main/java/cz/cvut/kbss/analysis/model/fta/CutSetExtractor.java
Outdated
Show resolved
Hide resolved
blcham
requested changes
Feb 11, 2024
There was a problem hiding this comment.
LGTM, just please remove the commented code.
Moreover, within the FaultTreeControler, I found the REST method to compute cuts but did not find the REST method to retrieve cuts. Thus, make sure it is retrievable from REST API.
Also, consider making some JUNIT tests if they are simple.
- extract new cutsets and repalce old in fault tree - persist the update
…ryService.performCutSetAnalysis
kostobog
force-pushed
the
feature/59-implement-simple-fault-tree-cutsets
branch
from
a037e6f to
f242c40
Compare
…comparing instances without AbstractEntity.uri is not set.
kostobog
force-pushed
the
feature/59-implement-simple-fault-tree-cutsets
branch
from
1bea759 to
3bc3d70
Compare
|
For now cutsets are fetched as the property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.