Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependencies suggested by dependabot #227

Closed
blcham opened this issue Oct 3, 2024 · 5 comments
Closed

Resolve dependencies suggested by dependabot #227

blcham opened this issue Oct 3, 2024 · 5 comments
Assignees

Comments

@blcham
Copy link

blcham commented Oct 3, 2024

image

See also:

A/C:

  • all dependencies are upgraded or argumented why not upgrade them
@blcham
Copy link
Author

blcham commented Oct 3, 2024

@palagdan do not upgrade Bootstrap, as I predicted, there is an issue with that, see kbss-cvut/s-forms#362

@palagdan
Copy link
Collaborator

palagdan commented Oct 4, 2024

@blcham
I've updated and tested all dependencies(not Bootstrap), they work correct in RM.

I will read the migration guide for bootstrap and try to resolve the problems with the styles.

palagdan added a commit that referenced this issue Oct 6, 2024
Replace deprecated Jumbotron with mui Paper
@blcham
Copy link
Author

blcham commented Oct 7, 2024

@palagdan, shouldn't the upgrade be done to SForms as well?

@palagdan
Copy link
Collaborator

palagdan commented Oct 7, 2024

@blcham

Yes, the bottom margin should be fixed
s-forms-update

palagdan added a commit that referenced this issue Oct 7, 2024
Replace deprecated Jumbotron with bootstrap classes
palagdan added a commit that referenced this issue Oct 8, 2024
Replace deprecated Jumbotron with bootstrap classes
palagdan added a commit that referenced this issue Oct 8, 2024
@blcham
Copy link
Author

blcham commented Oct 8, 2024

Closing as all deps were resolved while bootstrap will be handled in #215.

@blcham blcham closed this as completed Oct 8, 2024
palagdan added a commit that referenced this issue Oct 28, 2024
palagdan added a commit that referenced this issue Oct 28, 2024
palagdan added a commit that referenced this issue Nov 4, 2024
Replace deprecated Jumbotron with bootstrap classes
palagdan added a commit that referenced this issue Nov 19, 2024
blcham pushed a commit that referenced this issue Nov 26, 2024
Replace deprecated Jumbotron with bootstrap classes
blcham pushed a commit that referenced this issue Nov 26, 2024
blcham pushed a commit that referenced this issue Nov 26, 2024
blcham pushed a commit that referenced this issue Nov 26, 2024
blcham pushed a commit that referenced this issue Nov 26, 2024
blcham pushed a commit that referenced this issue Nov 26, 2024
palagdan added a commit that referenced this issue Nov 27, 2024
Replace deprecated Jumbotron with bootstrap classes
palagdan added a commit that referenced this issue Nov 27, 2024
palagdan added a commit that referenced this issue Nov 27, 2024
palagdan added a commit that referenced this issue Nov 27, 2024
palagdan added a commit that referenced this issue Nov 27, 2024
palagdan added a commit that referenced this issue Nov 27, 2024
palagdan added a commit that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants