Bump bootstrap from 4.6.2 to 5.0.0 #215

dependabot · 2024-10-02T12:53:40Z

Bumps bootstrap from 4.6.2 to 5.0.0.

Release notes

v5.0.0

Highlights

#32155: Updated make-col() mixin to generate equal columns when no size is specified #32763: Added new color-scheme() mixin #33389: Dropdown menus now have option become clickable #33453: Added new docs footer #33548: Offcanvas header components are now vertically aligned #33549: Added offcanvas-top modifier #33634: Added support for .dropdown-items wrapped in <li>s #33626: Fix v5 regressions in tab dropdown functionality

🚀 Features

#32763: Add color-scheme mixin

#33389: Dropdown — Add option to make the dropdown menu clickable

#33549: Add offcanvas-top modifier

🎨 CSS

#32155: Add equal column mixin

#32763: Add color-scheme mixin

#33292: Make accordion icon rotation more natural

#33411: Fix validation feedback icon in select multiple

#33478: Make .nav-link color consistent when using buttons

#33482: Dropdown — Apply positioning only when Popper is not used

#33548: Vertically align offcanvas header components

#33549: Add offcanvas-top modifier

#33550: Spinner alignment changes

#33598: Hide validation icons from multiple selects

#33600: Have $form-check-input-border's default derive from $black

#33607: Reduce color-scheme complexity

#33642: use :read-only css selector instead [readonly] for consistency

#33658: fix: use list-group variable instead of alert

#33736: accordion: fix border-top on Firefox

☕️ JavaScript

#32439: Decouple BackDrop from modal

#33245: Decouple Modal's scrollbar functionality

#33249: Simplify Modal Config

#33250: Simplify ScrollSpy config

#33310: fix: make EventHandler better handle mouseenter/mouseleave events

#33389: Dropdown — Add option to make the dropdown menu clickable

#33429: Remove element event listeners through base component

#33451: Add missing things in hide method of dropdown

#33456: Use our isDisabled util on dropdown

#33466: Refactor dropdown's hide functionality

#33479: Fix dropdown escape propagation

#33496: Use cached noop function

... (truncated)

Commits

bf09367 Release v5.0.0 (#33647)
48ae5a7 Rewrite migration guide (#33834)
f086572 refactor(docs): Added form file input variables (#33833)
1a54286 Fix doc typo and Bootstrap Icons link (#33832)
e2df73f Update migration guide for some v5 changes (#33829)
1e6356a Neutralise more words from placeholder text (#33731)
6633845 Bump eslint-config-xo from 0.35.0 to 0.36.0 (#33646)
cb38744 Tweak toast docs (#33810)
c2ff225 Bump rollup from 2.46.0 to 2.47.0 (#33818)
c090ea2 Bump @babel/preset-env from 7.14.0 to 7.14.1 (#33819)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

palagdan · 2024-10-07T07:44:32Z

@blcham

I noticed that react-bootstrap isn't compatible with the new version of Bootstrap, so the first step was updating it to the latest version. This fixed issues with the icons and possibly other things, though I primarily noticed the icons.

Next, the jumbotron (the gray dashboard) was deprecated. Bootstrap suggests using their updated classes to achieve a similar design, but I remembered there's a nice component for this in the MUI library called Paper, which is already being used in other KBSS projects:

I think it looks even better than before.

Another issue was the lack of bottom margin in input fields after the Bootstrap update. To fix this, I added a default mb-3 class to the input fields. We should apply the same fix to the s-forms.

I also replaced the deprecated InputGroup.Append with InputGroup.Text.

I replaced FormControl with FormSelect because FormControl started to look strange for select input after the update. . Also I replaced renamed bootstrap classes: "font-weight-bold text-lg-right align-self-center" with "fw-bold text-lg-end align-self-center".

The last issue I'm still working on is the big padding between buttons in a row, which only appears on larger screens:

blcham · 2024-10-07T10:40:52Z

@LaChope please have a look :)

blcham · 2024-10-07T10:49:38Z

@palagdan

MUI library called Paper

I understand MUI as an alternative to Bootstrap, having different philosophies on how styling works and is applied in source code.
I would be afraid to combine them without having a really good reason to do that.

Another issue was the lack of bottom margin in input fields after the Bootstrap update. To fix this, I added a default mb-3 class to the input fields. We should apply the same fix to the s-forms.

Ok, you can work on that.

package.json

src/components/dashboard/Dashboard.jsx

palagdan · 2024-10-08T10:33:29Z

Now it looks normal.

blcham

LGTM, but not sure if we can safely merge:

to me it seems safer to merge SForms migration to bootstrap 5 first, but if you are sure it will work correctly you can merge now

blcham

LGTM, can be rebased+merged If my comments are resolved, just do not forget to use new version of SForms ... we need to bump it as well

blcham · 2024-11-01T09:03:02Z

src/components/HelpIcon.jsx

-    <OverlayTrigger placement="right" overlay={tooltip}>
-      {icon()}
-    </OverlayTrigger>
+    <>


The new source code looks kinda complicated... Why we had to do this? OverlayTrigger does not exist anymore?

Or Bootstrap 5 does not support tooltips anymore?

By the way I see:
import { OverlayTrigger, Popover, Table } from "react-bootstrap";

in file

record-manager-ui/src/components/record/RecordTable.jsx

Line 2 in 64ff5e3

import { OverlayTrigger, Popover, Table } from "react-bootstrap";

How is it related? Isn't Popover alternative to tooltips? If so, we should definitely unify the way -- i.e., having Popover in both places or not having Popover at all !?

I was struggling with OverlayTrigger. After migrating, the tooltip was rendering outside of the window, and I couldn't fix its position. In the latest commit, I replaced OverlayTrigger with the Overlay component from Bootstrap, which resolved the issue. I also removed the popover.

package.json

blcham

See my comments.

blcham · 2024-11-01T09:09:02Z

src/components/HelpIcon.jsx

-    <OverlayTrigger placement="right" overlay={tooltip}>
-      {icon()}
-    </OverlayTrigger>
+    <>


By the way I see:
import { OverlayTrigger, Popover, Table } from "react-bootstrap";

in file

record-manager-ui/src/components/record/RecordTable.jsx

Line 2 in 64ff5e3

import { OverlayTrigger, Popover, Table } from "react-bootstrap";

How is it related? Isn't Popover alternative to tooltips? If so, we should definitely unify the way -- i.e., having Popover in both places or not having Popover at all !?

blcham · 2024-11-01T10:18:26Z

@palagdan Just so i am able to add A/C i created #236 and referenced it here

palagdan · 2024-11-04T12:09:45Z

@blcham, I also updated Node to version 18 in the Dockerfile because there were some errors during the build process.

blcham · 2024-11-19T15:10:19Z

👀

palagdan · 2024-11-19T15:28:00Z

@blcham

We need to publish a new version of SForms to NPM so I can test it with RM.

blcham · 2024-11-19T15:32:24Z

@palagdan you can use:

concrete beta version if PR was merged to the main
concrete alpha version if PR is still open

blcham · 2024-11-19T15:40:08Z

Not sure, but believe you can deduce "name of version" from hash of the last commit

palagdan · 2024-11-25T18:55:25Z

@blcham
I replaced an Overlay with OverlayTrigger, so I think it is ready to be merged.

deploy/shared/db-server/import/record-manager-formgen/forms/example-2-form.ttl

blcham

@palagdan LGTM, but I do not understand why you did not upgrade s-forms in package.json to the version where SForms is migrated to bootstrap 5.0.0

You can use s-forms 0.8.0 for it (I have just released this version)

palagdan · 2024-11-27T09:03:12Z

@blcham

I thought we would discuss first which version of SForms to use. I checked https://www.npmjs.com/package/@kbss-cvut/s-forms and there is no 0.8.0 there.

blcham · 2024-11-27T09:34:53Z

@palagdan sry, it should be there now -- https://www.npmjs.com/package/@kbss-cvut/s-forms/v/0.8.0

Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.2 to 5.0.0. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v4.6.2...v5.0.0) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

Replace deprecated Jumbotron with bootstrap classes

…rmSelect

dependabot bot added the dependencies Pull requests that update a dependency file label Oct 2, 2024

dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch 2 times, most recently from 37b7f8f to e3e95d0 Compare October 3, 2024 11:53

blcham force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from e3e95d0 to e66982c Compare October 3, 2024 14:37

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from ca7db4f to ede0a90 Compare October 6, 2024 11:50

LaChope requested changes Oct 7, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/components/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch 2 times, most recently from 43fa980 to 2324fc8 Compare October 8, 2024 10:23

palagdan requested a review from blcham October 8, 2024 10:33

blcham approved these changes Oct 8, 2024

View reviewed changes

blcham requested review from LaChope and removed request for LaChope October 8, 2024 11:09

blcham mentioned this pull request Oct 8, 2024

Resolve dependencies suggested by dependabot #227

Closed

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from fccbc3b to 8c96ea1 Compare October 28, 2024 13:18

blcham approved these changes Nov 1, 2024

View reviewed changes

blcham reviewed Nov 1, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

blcham requested changes Nov 1, 2024

View reviewed changes

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch 2 times, most recently from ef78a57 to f0fe3b3 Compare November 4, 2024 12:07

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from f0fe3b3 to 741f8fb Compare November 19, 2024 11:16

palagdan requested a review from blcham November 25, 2024 18:54

blcham requested changes Nov 26, 2024

View reviewed changes

deploy/shared/db-server/import/record-manager-formgen/forms/example-2-form.ttl Outdated Show resolved Hide resolved

blcham force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from e4514ef to a447c6c Compare November 26, 2024 15:14

blcham approved these changes Nov 26, 2024

View reviewed changes

blcham self-requested a review November 26, 2024 22:03

blcham requested changes Nov 26, 2024

View reviewed changes

dependabot bot and others added 17 commits November 27, 2024 12:12

[#227] Update react-bootstrap

11f6d38

Replace deprecated Jumbotron with bootstrap classes

[#227] Fix bottom margin in horizontal input

acc02a2

[#227] Fix bootstrap 5 classes in horizontal input label

bbc243b

[#227] Fix deprecated InputGroup Append and replace FormControl to Fo…

c6a0d58

…rmSelect

[#227] Bump bootstrap from 5.0.0 to 5.3.3

928163d

[#227] Fix dashboard buttons width

7dc9357

[#227] Fix container max-width size

23184fd

[#227] Migrate outdated components and classes in filters

537f16b

[#227] Migrate renamed utilities

71f9803

[#227] Fix overlay position render

bdc0e4b

[#227] Update Node from v16 to v18

16ff89b

[#227] Fix help icon display in required attributes component

bac53ba

Fix issues of forms related to codelists

6bd0204

[#227] Replace Overlay with OverlayTrigger

e5ac0bf

Fix example form comment

0251478

[#227] Update s-froms to 0.8.0

186a8f9

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from a447c6c to 186a8f9 Compare November 27, 2024 11:12

palagdan requested a review from blcham November 27, 2024 11:21

blcham merged commit 237d369 into main Nov 27, 2024
2 checks passed

blcham deleted the dependabot/npm_and_yarn/bootstrap-5.0.0 branch November 27, 2024 11:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump bootstrap from 4.6.2 to 5.0.0 #215

Bump bootstrap from 4.6.2 to 5.0.0 #215

dependabot bot commented on behalf of github Oct 2, 2024 •

edited

Loading

palagdan commented Oct 7, 2024 •

edited

Loading

blcham commented Oct 7, 2024

blcham commented Oct 7, 2024 •

edited

Loading

palagdan commented Oct 8, 2024

blcham left a comment

blcham left a comment •

edited

Loading

blcham Nov 1, 2024

blcham Nov 1, 2024

blcham Nov 1, 2024 •

edited

Loading

palagdan Nov 4, 2024

blcham left a comment

blcham Nov 1, 2024 •

edited

Loading

blcham commented Nov 1, 2024 •

edited

Loading

palagdan commented Nov 4, 2024

blcham commented Nov 19, 2024

palagdan commented Nov 19, 2024

blcham commented Nov 19, 2024

blcham commented Nov 19, 2024

palagdan commented Nov 25, 2024

blcham left a comment

palagdan commented Nov 27, 2024 •

edited

Loading

blcham commented Nov 27, 2024 •

edited

Loading

Bump bootstrap from 4.6.2 to 5.0.0 #215

Bump bootstrap from 4.6.2 to 5.0.0 #215

Conversation

dependabot bot commented on behalf of github Oct 2, 2024 • edited Loading

v5.0.0

Highlights

🚀 Features

🎨 CSS

☕️ JavaScript

palagdan commented Oct 7, 2024 • edited Loading

blcham commented Oct 7, 2024

blcham commented Oct 7, 2024 • edited Loading

palagdan commented Oct 8, 2024

blcham left a comment

Choose a reason for hiding this comment

blcham left a comment • edited Loading

Choose a reason for hiding this comment

blcham Nov 1, 2024

Choose a reason for hiding this comment

blcham Nov 1, 2024

Choose a reason for hiding this comment

blcham Nov 1, 2024 • edited Loading

Choose a reason for hiding this comment

palagdan Nov 4, 2024

Choose a reason for hiding this comment

blcham left a comment

Choose a reason for hiding this comment

blcham Nov 1, 2024 • edited Loading

Choose a reason for hiding this comment

blcham commented Nov 1, 2024 • edited Loading

palagdan commented Nov 4, 2024

blcham commented Nov 19, 2024

palagdan commented Nov 19, 2024

blcham commented Nov 19, 2024

blcham commented Nov 19, 2024

palagdan commented Nov 25, 2024

blcham left a comment

Choose a reason for hiding this comment

palagdan commented Nov 27, 2024 • edited Loading

blcham commented Nov 27, 2024 • edited Loading

dependabot bot commented on behalf of github Oct 2, 2024 •

edited

Loading

palagdan commented Oct 7, 2024 •

edited

Loading

blcham commented Oct 7, 2024 •

edited

Loading

blcham left a comment •

edited

Loading

blcham Nov 1, 2024 •

edited

Loading

blcham Nov 1, 2024 •

edited

Loading

blcham commented Nov 1, 2024 •

edited

Loading

palagdan commented Nov 27, 2024 •

edited

Loading

blcham commented Nov 27, 2024 •

edited

Loading