Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject Message #233

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Reject Message #233

merged 6 commits into from
Nov 11, 2024

Conversation

palagdan
Copy link
Collaborator

@palagdan palagdan commented Oct 24, 2024

Resolves partially #205

@palagdan palagdan requested a review from blcham October 27, 2024 18:26
@palagdan
Copy link
Collaborator Author

palagdan commented Oct 27, 2024

@blcham

reject_button

hover_reject

@blcham
Copy link

blcham commented Nov 1, 2024

@palagdan i edited first comment of this PR so it does not close the issue immediately (as there are 2 parts of the implmenatation, frontend and backend)

Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

src/components/record/RecordController.jsx Outdated Show resolved Hide resolved
src/components/record/RecordRow.jsx Outdated Show resolved Hide resolved
src/constants/ActionConstants.js Outdated Show resolved Hide resolved
Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

@blcham
Copy link

blcham commented Nov 1, 2024

@palagdan thanks for the screenshots, it looks nice, just a small grammar-related suggestion:
image

@palagdan palagdan requested a review from blcham November 5, 2024 12:47
@blcham blcham force-pushed the 205-reject-message branch from 53eecd0 to 2d0ce68 Compare November 7, 2024 16:55
Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blcham blcham force-pushed the 205-reject-message branch from b464cc6 to 726b60a Compare November 11, 2024 15:17
@blcham blcham merged commit 15be05f into main Nov 11, 2024
2 checks passed
@blcham blcham deleted the 205-reject-message branch November 11, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants