Feature/vite migration #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in package.json
LaChope
reviewed
Feb 21, 2024
| import PropTypes from "prop-types"; | ||
|
|
||
| let HistoryPagination = (props) => ( | ||
| <nav className="d-flex justify-content-center"> |
There was a problem hiding this comment.
I think flexbox is much better than bootstrap but for consistency with the rest of the app I assume bootstrap should be used
blcham
requested changes
Feb 21, 2024
config/index.js
Outdated
| @@ -1,31 +1,36 @@ | |||
| /** | |||
| * Aggregated object of process.env and window.__config__ to allow dynamic configuration | |||
| */ | |||
|
|
|||
| const ENV_KEY_BASE = "RECORD_MANAGER_"; | |||
There was a problem hiding this comment.
- move config/index.js --> js folder similar to
https://github.com/kbss-cvut/termit-ui/blob/82158a85bd0ada831eb7f8f2cc8b03a9fe70f67c/src/util/Constants.ts#L20
| "build": "webpack --config ./webpack.config.js", | ||
| "preview": "vite preview", | ||
| "start": "vite", | ||
| "build": "vite build", | ||
| "build:static": "cross-env NODE_ENV=production STATIC=true webpack --env.prod -p --config ./webpack.config.js", |
| @@ -70,14 +72,17 @@ | |||
| "querystring-es3": "^0.2.1", | |||
| "redux-mock-store": "^1.5.4", | |||
| "style-loader": "^1.1.3", | |||
| "vite": "^5.1.2", | |||
| "vite-plugin-simple-html": "^0.1.2", | |||
| "start": "webpack serve --config ./webpack.config.js", | ||
| "build": "webpack --config ./webpack.config.js", | ||
| "preview": "vite preview", | ||
| "start": "vite", |
There was a problem hiding this comment.
Suggested change
| "start": "vite", | |
| "dev": "vite", |
| }, | ||
| plugins: [ | ||
| pluginReact(), | ||
| simpleHtmlPlugin({ |
There was a problem hiding this comment.
We do not need this ... it is configured by config.js
| }, | ||
| plugins: [ | ||
| pluginReact(), | ||
| simpleHtmlPlugin({ |
There was a problem hiding this comment.
Can we use config.js/.ENV for configuring it?
| ), | ||
| "import.meta.env.RECORD_MANAGER_API_URL": JSON.stringify(env.VITE_RECORD_MANAGER_API_URL), | ||
| "import.meta.env.RECORD_MANAGER_APP_TITLE": JSON.stringify(env.VITE_RECORD_MANAGER_APP_TITLE), | ||
| "import.meta.env.RECORD_MANAGER_DEV_SERVER_PORT": JSON.stringify(env.VITE_RECORD_MANAGER_DEV_SERVER_PORT), |
There was a problem hiding this comment.
we want to remove that and use https://vitejs.dev/config/shared-options.html#envprefix RECORD_MANAGER_
blcham
reviewed
Feb 21, 2024
| @@ -0,0 +1,32 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
We need history of this file and other files that were just moved. Move in git instead of remove + create.
|
Closing in favor of akaene#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #88
Zistili jsme: