[Fix] When term occurrence does not exist, let authorization consider…

… access to it allowed.
kbss-cvut · Dec 10, 2024 · 44fba54 · 44fba54
1 parent 569a0db
commit 44fba54
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...z/cvut/kbss/termit/service/security/authorization/TermOccurrenceAuthorizationService.java b/...z/cvut/kbss/termit/service/security/authorization/TermOccurrenceAuthorizationService.java
@@ -56,6 +56,6 @@ public boolean canModify(TermOccurrence occurrence) {
 
     @Transactional(readOnly = true)
     public boolean canModify(URI occurrenceId) {
-        return dao.find(occurrenceId).map(this::canModify).orElse(false);
+        return dao.find(occurrenceId).map(this::canModify).orElse(true);
     }
 }
diff --git a/...ut/kbss/termit/service/security/authorization/TermOccurrenceAuthorizationServiceTest.java b/...ut/kbss/termit/service/security/authorization/TermOccurrenceAuthorizationServiceTest.java
@@ -20,7 +20,6 @@
 import java.net.URI;
 import java.util.Optional;
 
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.verify;
@@ -79,8 +78,8 @@ void canModifyResolvesResourceVocabularyAndChecksIfUserCanModifyItWhenTermOccurr
     }
 
     @Test
-    void canModifyReturnsFalseWhenTermOccurrenceDoesNotExist() {
+    void canModifyReturnsTrueWhenTermOccurrenceDoesNotExist() {
         when(toDao.find(any())).thenReturn(Optional.empty());
-        assertFalse(sut.canModify(Generator.generateUri()));
+        assertTrue(sut.canModify(Generator.generateUri()));
     }
 }