Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kbss cvut/termit UI#449 excel import #289

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

ledsoft
Copy link
Contributor

@ledsoft ledsoft commented Aug 29, 2024

One more round of modifications of kbss-cvut/termit-ui#449 after user testing feedback.

…sisting it so that existing one can be removed.

If the template is used, it does not contain identifier column, so the id would be generated on persist. On repeated import, this leads to errors because the existing term is not removed before the new one is persisted.
…and different identifier.

Existing identifier would be deleted and re-inserted again, but a different identifier would lead to two terms with the same label (and different identifiers).
@ledsoft ledsoft merged commit 2722583 into development Aug 29, 2024
2 checks passed
@ledsoft ledsoft deleted the kbss-cvut/termit-ui#449-excel-import branch August 29, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant