[Bug kbss-cvut/termit-ui#511] URI validating on persist or update #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d before each persists and updates. Base repository will validate the identifier (URI) during each pre-persist and pre-update. InvalidIdentifierException caused by URISyntaxException will now provide error details to the client.
ledsoft
reviewed
Sep 19, 2024
| */ | ||
| public static boolean isCausedBy(final Throwable throwable, @NonNull final Class<? extends Throwable> cause) { | ||
| public static <T extends Throwable> Optional<T> isCausedBy(final Throwable throwable, @NonNull final Class<T> cause) { |
There was a problem hiding this comment.
The method name is now quite misleading.
Rename isCausedBy to findCause to reflect changed return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves kbss-cvut/termit-ui#511
BaseRepositoryServicewill now perform additional validation of the URI before each persist and update.URI is valid when it is null or valid URI according to
IdentifierResolver#isUri.RestExceptionHandlerwill now provide more detailed information onURISyntaxException.