Return *this from an assignment operator

kcat · Jun 21, 2024 · 3c9cb48 · 3c9cb48
1 parent f91c044
commit 3c9cb48
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/alc/backends/wasapi.cpp b/alc/backends/wasapi.cpp
@@ -224,11 +224,14 @@ struct PropVariant {
 public:
     PropVariant() { PropVariantInit(&mProp); }
     PropVariant(const PropVariant &rhs) : PropVariant{} { PropVariantCopy(&mProp, &rhs.mProp); }
-    PropVariant(PropVariant&& rhs) : PropVariant{} { PropVariantCopy(&mProp, &rhs.mProp); }
     ~PropVariant() { clear(); }
 
-    void operator=(const PropVariant &rhs) { PropVariantCopy(&mProp, &rhs.mProp); }
-    void operator=(PropVariant&& rhs) { PropVariantCopy(&mProp, &rhs.mProp); }
+    auto operator=(const PropVariant &rhs) -> PropVariant&
+    {
+        if(this != &rhs)
+            PropVariantCopy(&mProp, &rhs.mProp);
+        return *this;
+    }
 
     void clear() { PropVariantClear(&mProp); }