Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving init option from kpm #59

Closed
wants to merge 1 commit into from

Conversation

liangyuanpeng
Copy link
Contributor

Releated: #57

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@@ -54,7 +54,7 @@ func NewModInitCmd(cli *client.KpmClient) *cobra.Command {
}
}

initOpts := opt.InitOptions{
initOpts := options.ModInitOptions{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InitOption exist at https://github.com/kcl-lang/kpm and here is saying KPM CLI is deprecated https://github.com/kcl-lang/kpm?tab=readme-ov-file#note-

I need to add a param of version ,so i need move this InitOptions to this repo or i should update https://github.com/kcl-lang/kpm first?

There is some confusion here .

@Peefy @zong-zhe

@Peefy
Copy link
Contributor

Peefy commented Mar 12, 2024

LGTM

@liangyuanpeng liangyuanpeng marked this pull request as draft March 13, 2024 02:35
@Peefy
Copy link
Contributor

Peefy commented Mar 13, 2024

We will only abandon the part of KPM CLI and use kcl mod instead, while retaining all parts of kpm pkg. See this issue: kcl-lang/kcl#756

Besides, before the release of the next major version v0.9.0, we will push for the merger of CLI and toolchain repositories in the future. Currently, we can write the option in the kpm repository and reference it in the cli repository.

@liangyuanpeng
Copy link
Contributor Author

Currently, we can write the option in the kpm repository and reference it in the cli repository.

Thanks for quickly reply and let me create a KPM pr for it,closing..

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@Peefy
Copy link
Contributor

Peefy commented Mar 13, 2024

Thank you for the contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants