Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance kcl file generation with imports and JSON/YAML data #213

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #212

refactor: enhance kcl file generation with imports and JSON/YAML data

2. What is the scope of this PR (e.g. component or file name):

  • pkg/tools/gen/genkcl_jsonschema.go
  • pkg/tools/gen/genkcl_terraform.go
  • pkg/tools/gen/genkcl_yaml.go
  • pkg/tools/gen/types.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/tools/gen/genkcl_test.go

@coveralls
Copy link

coveralls commented Jan 15, 2024

Pull Request Test Coverage Report for Build 7525924242

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 62.821%

Totals Coverage Status
Change from base Build 7524685396: -0.07%
Covered Lines: 2908
Relevant Lines: 4629

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e31e167 into kcl-lang:main Jan 15, 2024
7 checks passed
@Peefy Peefy deleted the enhance-kcl-file-gen branch January 15, 2024 09:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants