Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doc gen html escape for default value #218

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 18, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: doc gen html escape for default value

2. What is the scope of this PR (e.g. component or file name):

  • pkg/tools/gen/templates/doc/schemaDoc.gotmpl

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/tools/gen/testdata/doc/pkg/server.k
  • pkg/tools/gen/testdata/doc/pkg/md/main.md

@Peefy Peefy requested a review from zong-zhe January 18, 2024 13:32
@Peefy Peefy merged commit 771f644 into kcl-lang:main Jan 24, 2024
7 checks passed
@Peefy Peefy deleted the feat-doc-gen-html-escape-for-default-value branch January 24, 2024 02:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
1 participant