Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typo in document of Configuration #266

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

StevenLeiZhang
Copy link
Contributor

@StevenLeiZhang StevenLeiZhang commented Feb 2, 2024

Fix: #265

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

github-actions bot commented Feb 2, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Peefy
Copy link
Contributor

Peefy commented Feb 2, 2024

@StevenLeiZhang Good Catch! Thank you for your contribution. LGTM! Could you please sign the CLA? After the testing is completed, I will merge it.

@StevenLeiZhang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Feb 2, 2024
@StevenLeiZhang
Copy link
Contributor Author

@StevenLeiZhang Good Catch! Thank you for your contribution. LGTM! Could you please sign the CLA? After the testing is completed, I will merge it.

Done

@Peefy Peefy merged commit fbd29b3 into kcl-lang:main Feb 2, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] typo in document of configration
2 participants