fix: fix lsp watcher. remove feature, wait for kcl mod metadata to …

…read only Signed-off-by: he1pa <[email protected]>
kcl-lang · Dec 12, 2024 · 693f9f9 · 693f9f9
1 parent 580c0c2
commit 693f9f9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/kclvm/tools/src/LSP/src/state.rs b/kclvm/tools/src/LSP/src/state.rs
@@ -193,13 +193,18 @@ impl LanguageServerState {
         for event in self.fs_event_watcher._receiver.try_iter() {
             if let Ok(e) = event {
                 match e.kind {
-                    notify::EventKind::Modify(_) => {
-                        let paths = e.paths;
-                        let kcl_config_file: Vec<PathBuf> = filter_kcl_config_file(&paths);
-                        if !kcl_config_file.is_empty() {
-                            return Some(Event::FileWatcher(FileWatcherEvent::ChangedConfigFile(
-                                kcl_config_file,
-                            )));
+                    notify::EventKind::Modify(kind) => {
+                        if let notify::event::ModifyKind::Data(data_change) = kind {
+                            if let notify::event::DataChange::Content = data_change {
+                                let paths = e.paths;
+                                let kcl_config_file: Vec<PathBuf> = filter_kcl_config_file(&paths);
+                                if !kcl_config_file.is_empty() {
+                                    // TODO: wait for fix `kcl mod metadata` to read only. Otherwise it will lead to an infinite loop
+                                    // return Some(Event::FileWatcher(
+                                    //     FileWatcherEvent::ChangedConfigFile(kcl_config_file),
+                                    // ));
+                                }
+                            }
                         }
                     }
                     notify::EventKind::Remove(remove_kind) => {

diff --git a/kclvm/tools/src/LSP/src/tests.rs b/kclvm/tools/src/LSP/src/tests.rs
@@ -1527,7 +1527,8 @@ fn complete_import_external_file_e2e_test() {
     }
 }
 
-#[test]
+// TODO: wait for fix `kcl mod metadata` to read only. Otherwise it will lead to an infinite loop
+// #[test]
 fn mod_file_watcher_test() {
     let path = PathBuf::from(".")
         .join("src")