Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add symbol to node and type symbol APIs #1004

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/codeql-kcl#7

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/src/service/into.rs
  • kclvm/api/src/service/service_impl.rs
  • kclvm/loader/src/lib.rs
  • kclvm/sema/src/core/symbol.rs
  • kclvm/spec/gpyrpc/gpyrpc.proto

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/api/src/service/service_impl.rs

@Peefy Peefy added semantic Issues or PRs related to kcl semantic and checker api Issues or PRs related to kcl rust native APIs and multi-lang APIs labels Jan 25, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Jan 25, 2024
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7650558722

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.787%

Totals Coverage Status
Change from base Build 7640291218: 0.0%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7650558715

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.5%) to 72.331%

Totals Coverage Status
Change from base Build 7640291218: -15.5%
Covered Lines: 43729
Relevant Lines: 60457

💛 - Coveralls

@Peefy Peefy merged commit 5b40623 into kcl-lang:main Jan 25, 2024
10 of 11 checks passed
@Peefy Peefy deleted the enhance-sematic-api branch January 25, 2024 06:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants