Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema resolver type value load attribute error messages #1010

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 26, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: schema resolver type value load attribute error messages

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/attr.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/resolver/test_fail_data/schema_type_value_attr.k

@Peefy Peefy added bug Something isn't working resolver labels Jan 26, 2024
@Peefy Peefy force-pushed the fix-resolver-schema-ty-value-load-attr branch from 8bf7da8 to dbd9a8b Compare January 26, 2024 14:12
@Peefy Peefy merged commit 09aa50f into kcl-lang:main Jan 26, 2024
8 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant