Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add field 'timeout' to TimeoutExecutor to specify the timeout and increase the timeout in the test case to 120 seconds #1033

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Feb 6, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fixed #948

2. What is the scope of this PR (e.g. component or file name):

compiler-base-parallel

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

If the number of threads started by the test reaches a large number randomly, e.g. 100000, some tasks will time out, resulting in a test ci failure. Therefore, set the timeout period to 120s

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…nd increase the timeout in the test case to 120 seconds

Signed-off-by: zongz <[email protected]>
@zong-zhe zong-zhe added the bug Something isn't working label Feb 6, 2024
@zong-zhe zong-zhe added this to the v0.8.0 Release milestone Feb 6, 2024
@zong-zhe zong-zhe requested review from i-zhen and Peefy February 6, 2024 11:04
@zong-zhe zong-zhe self-assigned this Feb 6, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2024

Pull Request Test Coverage Report for Build 7798672580

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 241 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.5%) to 72.333%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 0.0%
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 11 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
Totals Coverage Status
Change from base Build 7781409227: -15.5%
Covered Lines: 43870
Relevant Lines: 60650

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 80f6849 into kcl-lang:main Feb 6, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CompilerBase CI sometimes fails
3 participants