Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kpm_update.rs with working tests #1040

Merged
merged 13 commits into from
Feb 21, 2024
Merged

Added kpm_update.rs with working tests #1040

merged 13 commits into from
Feb 21, 2024

Conversation

d4v1d03
Copy link
Contributor

@d4v1d03 d4v1d03 commented Feb 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Contains syntax changes
  • Contains experimental features
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test

Copy link

github-actions bot commented Feb 15, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@coveralls
Copy link
Collaborator

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 7987513826

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -26 of 53 (50.94%) changed or added relevant lines in 2 files are covered.
  • 108 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 71.797%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/driver/src/tests.rs 7 14 50.0%
kclvm/driver/src/kpm_update.rs 20 39 51.28%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/ty/mod.rs 12 88.1%
kclvm/tools/src/LSP/src/request.rs 14 66.44%
kclvm/tools/src/LSP/src/completion.rs 82 88.52%
Totals Coverage Status
Change from base Build 7986101701: -0.03%
Covered Lines: 44300
Relevant Lines: 61702

💛 - Coveralls

@d4v1d03
Copy link
Contributor Author

d4v1d03 commented Feb 15, 2024

I have read the CLA Document and I hereby sign the CLA

@d4v1d03
Copy link
Contributor Author

d4v1d03 commented Feb 15, 2024

recheck

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Feb 15, 2024
Signed-off-by: d4v1d03 <[email protected]>
@d4v1d03 d4v1d03 marked this pull request as draft February 18, 2024 11:36
@d4v1d03 d4v1d03 marked this pull request as ready for review February 21, 2024 08:21
kclvm/tools/src/vet/tests.rs Outdated Show resolved Hide resolved
Signed-off-by: d4v1d03 <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit b263455 into kcl-lang:main Feb 21, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants