-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: advance resolver incremental compile #1209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
reviewed
Apr 9, 2024
He1pa
changed the title
feat: advance resolver incremental compile
[wip]feat: advance resolver incremental compile
Apr 10, 2024
He1pa
changed the title
[wip]feat: advance resolver incremental compile
feat: advance resolver incremental compile
Apr 12, 2024
He1pa
force-pushed
the
advance_resolver_cache
branch
2 times, most recently
from
April 12, 2024 06:31
6b8d04c
to
d7bb85a
Compare
He1pa
force-pushed
the
advance_resolver_cache
branch
from
April 12, 2024 06:44
d7bb85a
to
29bfa67
Compare
Pull Request Test Coverage Report for Build 9345825692Details
💛 - Coveralls |
Peefy
reviewed
Apr 12, 2024
He1pa
force-pushed
the
advance_resolver_cache
branch
from
May 10, 2024 07:41
cea07d0
to
a8f1b06
Compare
He1pa
force-pushed
the
advance_resolver_cache
branch
from
June 3, 2024 06:11
a8f1b06
to
4dfb6f0
Compare
…solver support incremental compilation, clear cache by pkg and only update new pkg 2. Add gs cache in lsp state 3. Namer and Advanced Resolver modify gs in place(&mut) to reduce clone Signed-off-by: he1pa <[email protected]>
He1pa
force-pushed
the
advance_resolver_cache
branch
from
June 3, 2024 07:11
4dfb6f0
to
06bf195
Compare
Peefy
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shruti2522
added a commit
to shruti2522/kcl
that referenced
this pull request
Jun 3, 2024
Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add function symbol kind to lsp Signed-off-by: shruti2522 <[email protected]> update function symbol def Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> fix ci Signed-off-by: shruti2522 <[email protected]> fix ci Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add tests to sema_token Signed-off-by: shruti2522 <[email protected]> add get_function_symbol Signed-off-by: shruti2522 <[email protected]> highlight for func call Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> modify walk_call_expr Signed-off-by: shruti2522 <[email protected]> update namer for func_name Signed-off-by: shruti2522 <[email protected]> feat: distinguish highlight for func symbol and normal var symbol Signed-off-by: shruti2522 <[email protected]> update alloc_function_symbol Signed-off-by: shruti2522 <[email protected]> function symbol for builtin functions Signed-off-by: shruti2522 <[email protected]> update function symbol def Signed-off-by: shruti2522 <[email protected]> delete test.log Signed-off-by: shruti2522 <[email protected]> remove func symbol from walk_call_expr Signed-off-by: shruti2522 <[email protected]> update walk_call_expr for namer Signed-off-by: shruti2522 <[email protected]> update sema test Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add function symbol kind in global state Signed-off-by: shruti2522 <[email protected]> update hover to handle func symbolkind Signed-off-by: shruti2522 <[email protected]> add condition for symbolkind in hover Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> remove print statements Signed-off-by: shruti2522 <[email protected]> update loader snapshots Signed-off-by: shruti2522 <[email protected]> fix advanced resolver Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> update assign stmt for lambda expr Signed-off-by: shruti2522 <[email protected]> update resolve_names for identifier_expr Signed-off-by: shruti2522 <[email protected]> update semantic tokens with function type Signed-off-by: shruti2522 <[email protected]> feat: api list_variables supports get variables from multi-files (kcl-lang#1389) * feat: api list_variables supports get variables from multi-files Signed-off-by: zongz <[email protected]> * fix: fix CR comments Signed-off-by: zongz <[email protected]> * fix: fix test cases Signed-off-by: zongz <[email protected]> --------- Signed-off-by: zongz <[email protected]> feat: advance resolver incremental compile (kcl-lang#1209) feat: advanced resolver incremental compile. 1. Namer and Advanced Resolver support incremental compilation, clear cache by pkg and only update new pkg 2. Add gs cache in lsp state 3. Namer and Advanced Resolver modify gs in place(&mut) to reduce clone Signed-off-by: he1pa <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> remove duplicate code Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> remove repititions Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]>
Peefy
pushed a commit
that referenced
this pull request
Jun 3, 2024
…#1386) * feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add function symbol kind to lsp Signed-off-by: shruti2522 <[email protected]> update function symbol def Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> fix ci Signed-off-by: shruti2522 <[email protected]> fix ci Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add tests to sema_token Signed-off-by: shruti2522 <[email protected]> add get_function_symbol Signed-off-by: shruti2522 <[email protected]> highlight for func call Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> modify walk_call_expr Signed-off-by: shruti2522 <[email protected]> update namer for func_name Signed-off-by: shruti2522 <[email protected]> feat: distinguish highlight for func symbol and normal var symbol Signed-off-by: shruti2522 <[email protected]> update alloc_function_symbol Signed-off-by: shruti2522 <[email protected]> function symbol for builtin functions Signed-off-by: shruti2522 <[email protected]> update function symbol def Signed-off-by: shruti2522 <[email protected]> delete test.log Signed-off-by: shruti2522 <[email protected]> remove func symbol from walk_call_expr Signed-off-by: shruti2522 <[email protected]> update walk_call_expr for namer Signed-off-by: shruti2522 <[email protected]> update sema test Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add function symbol kind in global state Signed-off-by: shruti2522 <[email protected]> update hover to handle func symbolkind Signed-off-by: shruti2522 <[email protected]> add condition for symbolkind in hover Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> remove print statements Signed-off-by: shruti2522 <[email protected]> update loader snapshots Signed-off-by: shruti2522 <[email protected]> fix advanced resolver Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> update assign stmt for lambda expr Signed-off-by: shruti2522 <[email protected]> update resolve_names for identifier_expr Signed-off-by: shruti2522 <[email protected]> update semantic tokens with function type Signed-off-by: shruti2522 <[email protected]> feat: api list_variables supports get variables from multi-files (#1389) * feat: api list_variables supports get variables from multi-files Signed-off-by: zongz <[email protected]> * fix: fix CR comments Signed-off-by: zongz <[email protected]> * fix: fix test cases Signed-off-by: zongz <[email protected]> --------- Signed-off-by: zongz <[email protected]> feat: advance resolver incremental compile (#1209) feat: advanced resolver incremental compile. 1. Namer and Advanced Resolver support incremental compilation, clear cache by pkg and only update new pkg 2. Add gs cache in lsp state 3. Namer and Advanced Resolver modify gs in place(&mut) to reduce clone Signed-off-by: he1pa <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> remove duplicate code Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> remove repititions Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> * remove unwanted changes in global_state Signed-off-by: shruti2522 <[email protected]> remove unwanted changes in global_state Signed-off-by: shruti2522 <[email protected]> * fmt check Signed-off-by: shruti2522 <[email protected]> --------- Signed-off-by: shruti2522 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
sema/src/advanced_resolver
sema/src/core
sema/src/resolver
tools/src/LSP
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
advance resolver incremental compile
invalidate_pkgs
in resolverinvalidate_pkgs
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: