Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more api definitions in the kclvm api crate #1373

Merged
merged 1 commit into from
May 28, 2024
Merged

feat: add more api definitions in the kclvm api crate #1373

merged 1 commit into from
May 28, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 28, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add more api definitions in the kclvm api crate

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/src/lib.rs

zong-zhe
zong-zhe approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit b81f7b1 into kcl-lang:main May 28, 2024
8 of 10 checks passed
@Peefy Peefy deleted the feat-more-api-definitions branch May 28, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zong-zhe zong-zhe zong-zhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peefy @zong-zhe