Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix lambda expr scope range in advanced resolver #1439

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jun 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa force-pushed the fix_lambda_completion branch from ab816fc to 5b61600 Compare June 25, 2024 09:51
@He1pa He1pa force-pushed the fix_lambda_completion branch from 5b61600 to 4a0fcb2 Compare June 25, 2024 09:55
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented Jun 25, 2024

CI failed. cc @He1pa

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa force-pushed the fix_lambda_completion branch from f39edb3 to 9465e0e Compare June 26, 2024 02:41
Signed-off-by: he1pa <[email protected]>
@He1pa He1pa force-pushed the fix_lambda_completion branch from 9465e0e to 3e38f52 Compare June 26, 2024 03:03
@coveralls
Copy link
Collaborator

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9672877589

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 71.431%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 27 28 96.43%
Totals Coverage Status
Change from base Build 9660575177: 0.1%
Covered Lines: 55791
Relevant Lines: 78105

💛 - Coveralls

@Peefy Peefy merged commit e0b4791 into kcl-lang:main Jun 26, 2024
11 of 12 checks passed
@coveralls
Copy link
Collaborator

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9672877589

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 71.431%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 27 28 96.43%
Totals Coverage Status
Change from base Build 9660575177: 0.1%
Covered Lines: 55791
Relevant Lines: 78105

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants