Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local var scope in the evaluator #1456

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 28, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: local var scope in the evaluator

fix #1455
fix #1454

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator/src/context.rs
  • kclvm/evaluator/src/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/index_signature/normal_11/main.k
  • test/grammar/schema/init/init_schema_6/main.k

@Peefy Peefy added the bug Something isn't working label Jun 28, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Jun 28, 2024
@Peefy Peefy merged commit 3f2e611 into kcl-lang:main Jun 28, 2024
9 of 12 checks passed
@Peefy Peefy deleted the fix-local-var-scope-in-evaluator branch June 28, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant