Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hint API for the semantic model #1468

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 3, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1244

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/advanced_resolver/node.rs
  • kclvm/sema/src/core/symbol.rs
  • kclvm/tools/src/LSP/src/inlay_hints.rs
  • kclvm/tools/src/LSP/src/request.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/tools/src/LSP/src/snapshots/kcl_language_server__inlay_hints__tests__assign_stmt_type_hint.snap

@Peefy Peefy force-pushed the feat-symbol-hint branch from be0b083 to 524a841 Compare July 3, 2024 07:53
@coveralls
Copy link
Collaborator

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9773907484

Details

  • 103 of 136 (75.74%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 71.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/request.rs 0 1 0.0%
kclvm/sema/src/advanced_resolver/node.rs 32 35 91.43%
kclvm/tools/src/LSP/src/inlay_hints.rs 35 45 77.78%
kclvm/sema/src/core/symbol.rs 36 55 65.45%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 87.24%
kclvm/sema/src/core/symbol.rs 6 49.64%
Totals Coverage Status
Change from base Build 9773808424: 0.07%
Covered Lines: 56282
Relevant Lines: 78701

💛 - Coveralls

@Peefy Peefy merged commit b6e0c0b into kcl-lang:main Jul 3, 2024
9 of 11 checks passed
@Peefy Peefy deleted the feat-symbol-hint branch July 3, 2024 08:22
@coveralls
Copy link
Collaborator

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9773972403

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 136 (75.74%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 71.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/request.rs 0 1 0.0%
kclvm/sema/src/advanced_resolver/node.rs 32 35 91.43%
kclvm/tools/src/LSP/src/inlay_hints.rs 35 45 77.78%
kclvm/sema/src/core/symbol.rs 36 55 65.45%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 87.24%
kclvm/sema/src/core/symbol.rs 6 49.64%
Totals Coverage Status
Change from base Build 9773808424: 0.07%
Covered Lines: 56282
Relevant Lines: 78701

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9773907484

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 136 (75.74%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 71.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/request.rs 0 1 0.0%
kclvm/sema/src/advanced_resolver/node.rs 32 35 91.43%
kclvm/tools/src/LSP/src/inlay_hints.rs 35 45 77.78%
kclvm/sema/src/core/symbol.rs 36 55 65.45%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 87.24%
kclvm/sema/src/core/symbol.rs 6 49.64%
Totals Coverage Status
Change from base Build 9773808424: 0.07%
Covered Lines: 56282
Relevant Lines: 78701

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants