-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lsp file watcher. #1744
Merged
Merged
feat: lsp file watcher. #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He1pa
force-pushed
the
lsp_file_watcher
branch
from
November 6, 2024 10:51
0cd3ca4
to
ce67f12
Compare
…hanges will not be notified through lsp, e.g., execute `kcl mod add xxx`, `kcl fmt xxx` Signed-off-by: he1pa <[email protected]>
He1pa
force-pushed
the
lsp_file_watcher
branch
from
November 6, 2024 10:59
ce67f12
to
e73f312
Compare
Signed-off-by: he1pa <[email protected]>
Pull Request Test Coverage Report for Build 11721570179Details
💛 - Coveralls |
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Peefy
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
He1pa
force-pushed
the
lsp_file_watcher
branch
from
November 7, 2024 05:48
4c4bfe0
to
9a3497d
Compare
He1pa
force-pushed
the
lsp_file_watcher
branch
4 times, most recently
from
November 7, 2024 10:04
055eea3
to
9f4d8d8
Compare
Signed-off-by: he1pa <[email protected]>
He1pa
force-pushed
the
lsp_file_watcher
branch
from
November 7, 2024 10:54
9f4d8d8
to
f70f256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kcl mod add xxx
,kcl fmt xxx
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
[bug] After updating dependencies through commands, lsp cannot be automatically updated #1623
[WIP] KCL configuration files watch system design #1564
2. What is the scope of this PR (e.g. component or file name):
lsp/*
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
kcl mod add xxx
,kcl fmt xxx
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: