Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a function to parse all kcl files in the given path and opts #1749

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 13, 2024

Add a function to parse all kcl files in the given path and optss.
Different from load_program, this function will compile files that are not imported.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y Preparing for#1546

2. What is the scope of this PR (e.g. component or file name):

kclvm/parser/src/lib.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add a function to parse all kcl files in the given path and optss.
Different from load_program, this function will compile files that are not imported.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…s. Different from load_program, this function will compile files that are not imported.

Signed-off-by: he1pa <[email protected]>
@He1pa He1pa force-pushed the get_all_schema_type branch from 45bc24f to 1112f93 Compare November 13, 2024 07:12
@coveralls
Copy link
Collaborator

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11812384342

Details

  • 171 of 235 (72.77%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 70.722%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lib.rs 146 210 69.52%
Totals Coverage Status
Change from base Build 11789673643: 0.02%
Covered Lines: 52539
Relevant Lines: 74289

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 9016255 into main Nov 13, 2024
13 checks passed
@Peefy Peefy deleted the get_all_schema_type branch November 13, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants