Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: replace verbose completion tests with snapshot-based macro invocations #1780

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SkySingh04
Copy link

@SkySingh04 SkySingh04 commented Dec 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references:

2. What is the scope of this PR (e.g. component or file name):

/tools/src/LSP/src/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@SkySingh04 SkySingh04 force-pushed the completion-unit-tests branch from 44f37f7 to 4a32c48 Compare December 10, 2024 14:53
@zong-zhe
Copy link
Contributor

Hi @SkySingh04 😄

The github action issue I have fixed in the main branch, try rebase main branch

@SkySingh04
Copy link
Author

@zong-zhe @He1pa Let me know if any changes are required!

@He1pa
Copy link
Contributor

He1pa commented Dec 16, 2024

CI is broken now. Just wait for us to fix ci first. We will notify you when it is completed

@He1pa
Copy link
Contributor

He1pa commented Dec 16, 2024

It looks like you didn't add the new snapshots file to git

@SkySingh04 SkySingh04 force-pushed the completion-unit-tests branch from 0fc8596 to ccc3aa0 Compare December 17, 2024 03:39
@SkySingh04
Copy link
Author

@He1pa The snapshots have been added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] refactor lsp tests
3 participants