Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: str type var builtin function hover #759

Merged
merged 2 commits into from
Oct 11, 2023
Merged

bugfix: str type var builtin function hover #759

merged 2 commits into from
Oct 11, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 11, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

tools/src

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

bugfix: str type var builtin function hover

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added bug Something isn't working lsp labels Oct 11, 2023
@He1pa He1pa added this to the v0.7.0 Release milestone Oct 11, 2023
@He1pa He1pa requested review from i-zhen and Peefy October 11, 2023 06:44
@He1pa He1pa self-assigned this Oct 11, 2023
Peefy
Peefy reviewed Oct 11, 2023
View reviewed changes
kclvm/tools/src/LSP/src/goto_def.rs Show resolved Hide resolved
kclvm/tools/src/LSP/src/goto_def.rs Outdated Show resolved Hide resolved
i-zhen
i-zhen approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@i-zhen i-zhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa
fmt: fmt code
b77864d 
Signed-off-by: He1pa <[email protected]>
Peefy
Peefy approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit f63c71b into kcl-lang:main Oct 11, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Peefy Peefy Peefy approved these changes

@i-zhen i-zhen i-zhen approved these changes

Assignees

@He1pa He1pa

Labels
bug Something isn't working lsp
Projects
No open projects
KCL 2023
Status: v0.7.0 Release Done
Milestone
v0.7.0 Release
Development

Successfully merging this pull request may close these issues.

[Bug] String variable missing member function hover
3 participants
@He1pa @i-zhen @Peefy