-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format behavior of union types #790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Peefy
reviewed
Oct 18, 2023
amyXia1994
force-pushed
the
fix/format
branch
from
October 18, 2023 13:06
b59b4c3
to
1fb9105
Compare
Peefy
added
the
tool
Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
label
Oct 18, 2023
Signed-off-by: xiarui.xr <[email protected]>
amyXia1994
force-pushed
the
fix/format
branch
from
October 18, 2023 14:20
1fb9105
to
a4f6be2
Compare
Peefy
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amyXia1994
force-pushed
the
fix/format
branch
from
October 19, 2023 03:43
26b6c0e
to
02ce941
Compare
Pull Request Test Coverage Report for Build 6574118919
💛 - Coveralls |
amyXia1994
force-pushed
the
fix/format
branch
from
October 19, 2023 08:39
02ce941
to
33f6283
Compare
Signed-off-by: xiarui.xr <[email protected]>
amyXia1994
force-pushed
the
fix/format
branch
from
October 19, 2023 11:47
33f6283
to
bd0cc53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
tool
Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re [Enhancement][Track] Formatting tools with KCL Code style specifications #627
2. What is the scope of this PR (e.g. component or file name):
fix the to string impl of union type:
test cases:
kclvm/tools/src/format/test_data/format_data/union_types.golden
kclvm/tools/src/format/test_data/format_data/union_types.input
kclvm/tools/src/format/tests.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
fix: format behavior of union types
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: