Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format behavior of union types #790

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

fix the to string impl of union type:

  • kclvm/ast/src/ast.rs

test cases:
kclvm/tools/src/format/test_data/format_data/union_types.golden
kclvm/tools/src/format/test_data/format_data/union_types.input
kclvm/tools/src/format/tests.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix: format behavior of union types

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@amyXia1994 amyXia1994 requested a review from Peefy October 18, 2023 12:24
@amyXia1994 amyXia1994 marked this pull request as ready for review October 18, 2023 12:25
@Peefy Peefy added this to the v0.7.0 Release milestone Oct 18, 2023
@Peefy Peefy added the tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. label Oct 18, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Oct 19, 2023

Pull Request Test Coverage Report for Build 6574118919

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6562245967: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

Signed-off-by: xiarui.xr <[email protected]>
@Peefy Peefy merged commit 055ae28 into kcl-lang:main Oct 19, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
@amyXia1994 amyXia1994 deleted the fix/format branch October 20, 2023 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants