-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Defend against non-KCL files #798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He1pa
force-pushed
the
lsp_defend_non_kcl_file
branch
from
October 23, 2023 10:07
059900c
to
c8b4a4c
Compare
Peefy
reviewed
Oct 23, 2023
Pull Request Test Coverage Report for Build 6637757784
💛 - Coveralls |
Peefy
reviewed
Oct 23, 2023
He1pa
force-pushed
the
lsp_defend_non_kcl_file
branch
from
October 25, 2023 06:00
3151282
to
c5b7b3a
Compare
…n the client renames a file, if the file suffix is changed, some requests will also be sent. However, it is considered not a valid kcl file during compilation, which will cause lsp panic. Signed-off-by: He1pa <[email protected]>
Signed-off-by: He1pa <[email protected]>
He1pa
force-pushed
the
lsp_defend_non_kcl_file
branch
from
October 25, 2023 08:29
c5b7b3a
to
3fe8feb
Compare
Peefy
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client renames a file, if the file suffix is changed, some requests will also be sent. However, it is considered not a valid kcl file during compilation, which will cause lsp panic.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
tools/lsp
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
When the client renames a file, if the file suffix is changed, some requests will also be sent. However, it is considered not a valid kcl file during compilation, which will cause lsp panic.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: