Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: enhance lsp completion for function. #799

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 25, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

lsp completion

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add parentheses when complete function call. e.g.,

math.  -> math.exp

enhance to

math.  -> math.exp()
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added the lsp label Oct 25, 2023
@He1pa He1pa added this to the v0.7.0 Release milestone Oct 25, 2023
@He1pa He1pa self-assigned this Oct 25, 2023
@He1pa He1pa changed the title fix: fix lsp completion for function. … enhance: enhance lsp completion for function. Oct 25, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6635569621

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6611493607: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

@He1pa He1pa force-pushed the fix_completion_func branch from dbfcbed to 1caef9b Compare October 25, 2023 08:27
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit f3d8614 into kcl-lang:main Oct 25, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants