Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the lambda argument type, when it is schema type, into schema type instance #803

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Oct 26, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #782

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Oct 26, 2023
@zong-zhe zong-zhe added this to the v0.7.0 Release milestone Oct 26, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy October 26, 2023 03:40
@zong-zhe zong-zhe self-assigned this Oct 26, 2023
@Peefy Peefy changed the title fix: fix the lambda argument type, when it is schema type, into schem… fix: fix the lambda argument type, when it is schema type, into schema type instance Oct 26, 2023
@zong-zhe zong-zhe force-pushed the fix-lambda-arg-type branch from f8032e1 to 9f100c7 Compare October 26, 2023 03:42
Signed-off-by: zongz <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 4eac50d into kcl-lang:main Oct 26, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Bug] KCL doesn't handle imports and lambdas corrrectly
2 participants