Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance lsp completion detail #805

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 26, 2023

Add completion kind(icon in vscode), detail and doc in completion item. Enhance completion label for function

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp completion

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add completion kind(icon in vscode), detail and doc in completion item. Enhance completion label for function

image

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added the lsp label Oct 26, 2023
@He1pa He1pa added this to the v0.7.0 Release milestone Oct 26, 2023
@He1pa He1pa self-assigned this Oct 26, 2023
@He1pa He1pa force-pushed the enhance_completion_item_detail branch 2 times, most recently from df6a0a3 to f4dabf7 Compare October 26, 2023 08:05
@coveralls
Copy link
Collaborator

coveralls commented Oct 26, 2023

Pull Request Test Coverage Report for Build 6651253134

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6649509446: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

…de), detail and doc in completion item. Enhance completion label for function

Signed-off-by: He1pa <[email protected]>
@He1pa He1pa force-pushed the enhance_completion_item_detail branch from f4dabf7 to d35202f Compare October 26, 2023 08:09
Signed-off-by: He1pa <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1d9eccb into kcl-lang:main Oct 26, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Enhancement] completion on the parameter list of the built-in functions
3 participants