Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify TypeRef from Rc<Type> to Arc<Type> #827

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 1, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

sema

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

modify TypeRef from Rc to Arc

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa requested a review from amyXia1994 November 1, 2023 06:53
@He1pa He1pa self-assigned this Nov 1, 2023
@He1pa He1pa added semantic Issues or PRs related to kcl semantic and checker type-system Issues or PRs related to kcl type system labels Nov 1, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6717029703

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6715312352: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit bf3a1ca into kcl-lang:main Nov 1, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker type-system Issues or PRs related to kcl type system
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants