Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async build word index map when init lsp state #832

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 2, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

lsp/state.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

async build word index map when init lsp state, Konfig startup time reduced to 1/3 (27s -> 9s). There may still be some read-write locks

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

Konfig startup time reduced to 1/3 (27s -> 9s).

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa self-assigned this Nov 2, 2023
@He1pa He1pa added the lsp label Nov 2, 2023
@He1pa He1pa changed the title feat: sync build word index map when init lsp state feat: async build word index map when init lsp state Nov 2, 2023
@He1pa He1pa force-pushed the sync_build_word_index_map branch from a963808 to bf72c54 Compare November 2, 2023 03:59
@coveralls
Copy link
Collaborator

coveralls commented Nov 2, 2023

Pull Request Test Coverage Report for Build 6728910702

  • 21 of 25 (84.0%) changed or added relevant lines in 2 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.8%) to 70.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/state.rs 19 23 82.61%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6721267199: -17.8%
Covered Lines: 38395
Relevant Lines: 54809

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit c8786e3 into kcl-lang:main Nov 2, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants