Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp complete for exteranl pkg import #848

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 6, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp/completion

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

complete for exteranl pkg import

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

kclvm/tools/src/LSP/src/completion.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/completion.rs Outdated Show resolved Hide resolved
@He1pa He1pa force-pushed the lsp_complete_import_extern_pkg branch from 1c817c1 to e29384c Compare November 7, 2023 02:05
@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6779150182

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6779045512: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

Signed-off-by: He1pa <[email protected]>
@He1pa He1pa force-pushed the lsp_complete_import_extern_pkg branch from d1bfd8a to 6a27dfa Compare November 7, 2023 03:19
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 76f5a63 into kcl-lang:main Nov 7, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants