Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl yaml stream decode/encode system module functions #852

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 7, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #313

feat: impl yaml stream decode/encode system module functions

2. What is the scope of this PR (e.g. component or file name):

  • Runtime function impls kclvm/runtime/src/yaml/mod.rs
  • Semantic definitions: kclvm/sema/src/builtin/system_module.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/builtins/yaml/**

@Peefy Peefy added semantic Issues or PRs related to kcl semantic and checker runtime Issues or PRs related to kcl runtime including value and value opertions labels Nov 7, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Nov 7, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6780180680

  • 1 of 139 (0.72%) changed or added relevant lines in 4 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.6%) to 70.204%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/_kclvm_addr.rs 0 3 0.0%
kclvm/runtime/src/yaml/mod.rs 0 58 0.0%
kclvm/sema/src/builtin/system_module.rs 0 77 0.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6780128584: -17.6%
Covered Lines: 39442
Relevant Lines: 56182

💛 - Coveralls

@Peefy Peefy merged commit 350e34a into kcl-lang:main Nov 7, 2023
11 checks passed
@Peefy Peefy deleted the yaml-encode-all-for-yaml-stream-function branch November 7, 2023 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
runtime Issues or PRs related to kcl runtime including value and value opertions semantic Issues or PRs related to kcl semantic and checker
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

2 participants