Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl basic test suite loader and runner #901

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 21, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re: #178

  • feat: impl basic test suite loader and runner
  • todo: test tool APIs

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/driver/src/lib.rs
  • kclvm/runner/src/lib.rs
  • kclvm/runner/src/runner.rs
  • kclvm/tools/src/testing/mod.rs
  • kclvm/tools/src/testing/suite.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/tools/src/testing/tests.rs

@Peefy Peefy added the tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. label Nov 21, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Nov 21, 2023
@Peefy Peefy self-assigned this Nov 21, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6951873350

  • 244 of 278 (87.77%) changed or added relevant lines in 8 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.7%) to 72.147%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/runner.rs 15 16 93.75%
kclvm/tools/src/testing/mod.rs 2 3 66.67%
kclvm/runner/src/lib.rs 43 49 87.76%
kclvm/tools/src/testing/suite.rs 110 118 93.22%
kclvm/driver/src/lib.rs 38 56 67.86%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6940100502: -15.7%
Covered Lines: 41874
Relevant Lines: 58040

💛 - Coveralls

@Peefy Peefy force-pushed the feat-base-test-runner branch from a5131bc to 8406615 Compare November 21, 2023 14:05
@Peefy Peefy force-pushed the feat-base-test-runner branch from 8406615 to c521f50 Compare November 22, 2023 01:57
@Peefy Peefy changed the title [WIP] feat: impl basic test suite loader and runner feat: impl basic test suite loader and runner Nov 22, 2023
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 11043c4 into kcl-lang:main Nov 22, 2023
11 checks passed
@Peefy Peefy deleted the feat-base-test-runner branch November 22, 2023 06:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants