Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rule statement with index signature #920

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 27, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: support rule statement with index signature

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/sema/src/resolver/global.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/rule/rule_with_index_signature/main.k

@Peefy Peefy added semantic Issues or PRs related to kcl semantic and checker codegen labels Nov 27, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Nov 27, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2023

Pull Request Test Coverage Report for Build 7003649474

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.7%) to 72.151%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 7003138507: -15.7%
Covered Lines: 41882
Relevant Lines: 58048

💛 - Coveralls

@Peefy Peefy merged commit 7eb2aa2 into kcl-lang:main Nov 27, 2023
11 checks passed
@Peefy Peefy deleted the feat-schema-index-signature-inherit branch November 27, 2023 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
codegen semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants