Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix lsp completion for newline char #926

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 28, 2023

1 .dot completion of schema attr with schema type
2. newline completion of schema attr when cursor in schema_stmt

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

1 .dot completion of schema attr with schema type
2. newline completion of schema attr when cursor in schema_stmt

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy changed the title fix: fix lsp completion. fix: fix lsp completion for newline char Nov 28, 2023
@Peefy Peefy added the lsp label Nov 28, 2023
…type 2. newline completion of schema attr when cursor in schemastmt

Signed-off-by: he1pa <[email protected]>
@He1pa He1pa force-pushed the fix_newline_complete_in_schema_expr branch from 2e5f1d8 to d97e1d8 Compare November 28, 2023 09:26
Signed-off-by: he1pa <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7016709170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 79 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+15.1%) to 87.787%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 96.1%
compiler_base/span/src/span.rs 3 0.0%
compiler_base/error/src/unit_type.rs 5 0.0%
compiler_base/session/src/lib.rs 15 75.81%
compiler_base/error/src/diagnostic/components.rs 23 81.01%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 30 82.13%
Totals Coverage Status
Change from base Build 7016387853: 15.1%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

Signed-off-by: he1pa <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7017071588

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 79 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+15.1%) to 87.787%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 96.1%
compiler_base/span/src/span.rs 3 0.0%
compiler_base/error/src/unit_type.rs 5 0.0%
compiler_base/session/src/lib.rs 15 75.81%
compiler_base/error/src/diagnostic/components.rs 23 81.01%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 30 82.13%
Totals Coverage Status
Change from base Build 7016387853: 15.1%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7017071579

  • 66 of 75 (88.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 72.737%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/util.rs 12 14 85.71%
kclvm/tools/src/LSP/src/completion.rs 53 60 88.33%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/completion.rs 1 90.73%
Totals Coverage Status
Change from base Build 7016387853: 0.09%
Covered Lines: 42360
Relevant Lines: 58237

💛 - Coveralls

@Peefy Peefy merged commit e226b9a into kcl-lang:main Nov 28, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants