Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance lsp complete for function params #957

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Dec 19, 2023

enhance lsp complete for function params. use insert_text(place holder) to replace params name in CompletionItem label

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

… holder) to replace params name in CompletionItem label

Signed-off-by: he1pa <[email protected]>
@He1pa He1pa added the lsp label Dec 19, 2023
@He1pa He1pa added this to the v0.8.0 Release milestone Dec 19, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7258520917

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.787%

Totals Coverage Status
Change from base Build 7191500898: 0.0%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7258520919

  • 53 of 56 (94.64%) changed or added relevant lines in 1 file are covered.
  • 241 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.1%) to 72.657%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 53 56 94.64%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 0.0%
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 11 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
Totals Coverage Status
Change from base Build 7191500898: -15.1%
Covered Lines: 42772
Relevant Lines: 58868

💛 - Coveralls

@Peefy Peefy merged commit e14cbae into kcl-lang:main Dec 19, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants