Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance lsp complete for schema value and schema type. #961

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Dec 22, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

enhance lsp complete for schema value and schema type.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy added the lsp label Dec 22, 2023
@Peefy Peefy added this to the v0.8.0 Release milestone Dec 22, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7295630404

  • 45 of 45 (100.0%) changed or added relevant lines in 1 file are covered.
  • 241 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.2%) to 72.673%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 0.0%
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 11 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
Totals Coverage Status
Change from base Build 7283247858: -15.2%
Covered Lines: 42855
Relevant Lines: 58970

💛 - Coveralls

@Peefy Peefy merged commit 9d51894 into kcl-lang:main Dec 22, 2023
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants