Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run cargo clippy to fix warnings #969

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 3, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • chore: run cargo clippy to fix warnings

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added this to the v0.8.0 Release milestone Jan 3, 2024
@Peefy Peefy force-pushed the cargo-clippy-for-lsp-crate branch from cec5a95 to 40d2ce3 Compare January 4, 2024 02:28
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7404820725

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.0%) to 72.779%

Totals Coverage Status
Change from base Build 7382979999: -15.0%
Covered Lines: 43288
Relevant Lines: 59479

💛 - Coveralls

@Peefy Peefy merged commit 722dea3 into kcl-lang:main Jan 4, 2024
9 of 11 checks passed
@Peefy Peefy deleted the cargo-clippy-for-lsp-crate branch January 4, 2024 03:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants