Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat parser api for multiple SDKs #978

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #970

  • feat: impl ParseProgram and ParseFile API
  • refactor: load_program API in the parser crate and returns topologic sort for all compile files

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/src/service/capi.rs
  • kclvm/api/src/service/into.rs
  • kclvm/api/src/service/service_impl.rs
  • kclvm/parser/**
  • kclvm/ast/src/ast.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added parser Issues or PRs related to kcl parser api Issues or PRs related to kcl rust native APIs and multi-lang APIs labels Jan 11, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Jan 11, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7485056598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.1%) to 72.696%

Totals Coverage Status
Change from base Build 7476285374: -15.1%
Covered Lines: 43573
Relevant Lines: 59939

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit c9cf9c3 into kcl-lang:main Jan 11, 2024
10 of 11 checks passed
@Peefy Peefy deleted the feat-parser-api branch January 11, 2024 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] KCL Parser API for Multiple SDKs
3 participants