feat: update ApplicationBuilder for improved metadata, parameter compatibility, and env handling #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atibility, and env handling - added a new option parameter to set application metadata, enabling metadata specification within the KCLRun file. This addresses a limitation when building with the kcl kubeclt plugin. - renamed `env` to `appenv` and `cluster` to `appcluster` to avoid conflicts with system environment variables, especially when using `env` as a key in options with KCLRun. - modified `ApplicationBuilder` to use `EnvMap` instead of a list of dictionaries for envs, ensuring compatibility with the container env parameter structure. Signed-off-by: Emin Aktas <[email protected]>
eminaktas
force-pushed
the
add-params-option
branch
from
73e8477 to
7311458
Compare
|
Thank you! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
envtoappenvandclustertoappclusterto avoid conflicts with system environment variables, especially when usingenvas a key in options with KCLRun.ApplicationBuilderto useEnvMapinstead of a list of dictionaries for envs, ensuring compatibility with the container env parameter structure.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: