-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add struct 'KpmClient' to manage the settings of kpm #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
reviewed
Sep 25, 2023
) | ||
|
||
// CompileOptions is the input options of 'kpm run'. | ||
type CompileOptions struct { | ||
isVendor bool | ||
hasSettingsYaml bool | ||
entries []string | ||
// Add a writer to control the output of the compiler. | ||
writer io.Writer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format code.
Peefy
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Test Coverage Report for Build 6296472022
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
Add struct 'KpmClient' in pkg/client/client.go to manage the settings of kpm.
Copy the contents of some methods from the pkg/package/package.go and pkg/package/modfile.go into pkg/client/client.go.
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
Before this PR, kpm's methods were controlled through global settings, and the problem was that changing settings would affect all apis.
After this PR, Some methods are moved to pkg/client/client.go as member methods of KpmClient, and these methods are only controlled by KpmClient, and the methods of different KpmClients do not affect each other.
There is no change in the logic of the specific function that has been changed, only some of the original ‘ModFile’ and 'KclPkg' member methods are moved to 'KpmClient'.
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: