Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add '--quiet' to control the kpm log message #195

Merged
merged 1 commit into from
Oct 7, 2023
Merged

feat: add '--quiet' to control the kpm log message #195

merged 1 commit into from
Oct 7, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix issue #50

2. What is the scope of this PR (e.g. component or file name):

kpm.go
pkg/client/client.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe requested review from i-zhen and Peefy September 27, 2023 07:35
@zong-zhe zong-zhe self-assigned this Sep 27, 2023
@zong-zhe zong-zhe added the enhancement New feature or request label Sep 27, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6322837370

  • 58 of 144 (40.28%) changed or added relevant lines in 15 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 37.763%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 1 2 50.0%
pkg/oci/oci.go 0 2 0.0%
pkg/package/modfile.go 0 2 0.0%
pkg/package/toml.go 0 2 0.0%
pkg/cmd/cmd_init.go 0 4 0.0%
pkg/package/package.go 0 4 0.0%
pkg/cmd/cmd_pkg.go 0 5 0.0%
pkg/cmd/cmd_login.go 0 6 0.0%
pkg/cmd/cmd_logout.go 0 6 0.0%
pkg/cmd/cmd_push.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/cmd_init.go 1 0.0%
pkg/cmd/cmd_pkg.go 1 0.0%
pkg/cmd/cmd_push.go 1 10.26%
pkg/oci/oci.go 1 7.24%
Totals Coverage Status
Change from base Build 6296567387: -0.6%
Covered Lines: 1222
Relevant Lines: 3236

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 900a16d into kcl-lang:main Oct 7, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants