Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a symbolic link for the dependencies #215

Merged
merged 1 commit into from
Nov 17, 2023
Merged

feat: create a symbolic link for the dependencies #215

merged 1 commit into from
Nov 17, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Nov 17, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed KCL issue kcl-lang/kcl#891
Fixed KCL issue kcl-lang/kcl#823

2. What is the scope of this PR (e.g. component or file name):

pkg/client/client.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Nov 17, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy November 17, 2023 08:21
@zong-zhe zong-zhe self-assigned this Nov 17, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6901547285

  • 10 of 14 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 36.153%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 10 14 71.43%
Totals Coverage Status
Change from base Build 6876175793: 0.1%
Covered Lines: 1282
Relevant Lines: 3546

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit cb0e284 into kcl-lang:main Nov 17, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants